Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DomainNameValidator types #2498

Merged
merged 5 commits into from
Feb 4, 2025
Merged

DomainNameValidator types #2498

merged 5 commits into from
Feb 4, 2025

Conversation

HansAarneLiblik
Copy link
Contributor

I have made things!

I'm unable to use django.core.validators.DomainNameValidator in my project due to mypy complaining

error: Module "django.core.validators" has no attribute "DomainNameValidator" [attr-defined]

This should hopefully fix that issue

Related issues

  • None. I can create one, if needed

sobolevn
sobolevn approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sobolevn sobolevn merged commit add6826 into typeddjango:master Feb 4, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HansAarneLiblik @sobolevn