This repository was archived by the owner on Feb 18, 2021. It is now read-only.
Added support for no output image #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twolfson
force-pushed
the
dev/allow.no.image.sqwished
branch
from
2a84654 to
efb5072
Compare
|
IndigoUnited/node-buffered-spawn#5 was landed/released and this PR is now on top of the patched version. This PR is good to be reviewed/landed. |
|
👍 |
mlmorg
added a commit
that referenced
this pull request
Jun 23, 2015
Added support for no output image
|
Thanks @twolfson! |
|
Woot, thanks for the quick land @mlmorg =) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on IndigoUnited/node-buffered-spawn#5
As requested in #23, we should support no output image. This PR adds support for that by sending the diff image to
stdoutand ignoringstdout. In this PR:options.diffImagebuffered-spawnwhich supports ignoringstdoutOnce again, this depends on IndigoUnited/node-buffered-spawn#5 so please don't land it until that PR has been landed/released and this PR has been updated to use that version.
/cc @mlmorg