-
Notifications
You must be signed in to change notification settings - Fork 94
Added travis ci support for modern node versions #41
Conversation
@@ -1,5 +1,7 @@ | |||
language: node_js | |||
node_js: | |||
- "6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also add "5" and drop "iojs" from this list?
Sure thing! Fixed. |
- 4 | ||
- 0.12 | ||
- 0.11 | ||
- 0.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You stripped away the quotes, please keep them for reducing the noise in this PR =/
Looks like too much was fixed in that last commit. Left another comment. Can you please squash the commits into 1 commit as well? |
I haven't squashed a commit before. How would I do that? |
Run https://ariejan.net/2011/07/05/git-squash-your-latests-commits-into-one/ Once the commits are squashed into 1, you will need to force push the update. That can be done via: git push origin patch-1 --force |
Why don't we have node v6 being tested in this PR? Just joining this discussion. |
It is in this PR, maybe you are viewing a subset of the commits? https://github.com/uber/image-diff/pull/41/files#diff-354f30a63fb0907d4ad57269548329e3R3 |
The command
isnt working for me. It's returning |
You need to run the |
Also, make sure you are on the |
I see. Can I close this PR and make a new one with these revisions? |
You can but you should be able to do everything on this branch/PR =/ |
No description provided.