Skip to content
This repository was archived by the owner on Feb 18, 2021. It is now read-only.

Added travis ci support for modern node versions #41

Closed
wants to merge 3 commits into from

Conversation

amilajack
Copy link
Contributor

No description provided.

@@ -1,5 +1,7 @@
language: node_js
node_js:
- "6"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add "5" and drop "iojs" from this list?

@amilajack
Copy link
Contributor Author

Sure thing! Fixed.

- 4
- 0.12
- 0.11
- 0.10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You stripped away the quotes, please keep them for reducing the noise in this PR =/

@twolfson
Copy link
Contributor

Looks like too much was fixed in that last commit. Left another comment. Can you please squash the commits into 1 commit as well?

@amilajack
Copy link
Contributor Author

I haven't squashed a commit before. How would I do that?

@twolfson
Copy link
Contributor

Run git rebase -i master and change all commits except for the first 1 to "squash". Here's a demonstration:

https://ariejan.net/2011/07/05/git-squash-your-latests-commits-into-one/

Once the commits are squashed into 1, you will need to force push the update. That can be done via:

git push origin patch-1 --force

@dawsbot
Copy link

dawsbot commented Jul 15, 2016

Why don't we have node v6 being tested in this PR? Just joining this discussion.

@twolfson
Copy link
Contributor

@amilajack
Copy link
Contributor Author

The command

git push origin patch-1 --force

isnt working for me. It's returning Everything up-to-date but the squash doesnt seem to be pushed.

@twolfson
Copy link
Contributor

You need to run the git rebase -i master first and choose "squash" for all but the first commit as instructed =/

@twolfson
Copy link
Contributor

Also, make sure you are on the patch-1 branch when running git rebase

@amilajack
Copy link
Contributor Author

I see. Can I close this PR and make a new one with these revisions?

@twolfson
Copy link
Contributor

You can but you should be able to do everything on this branch/PR =/

@amilajack amilajack closed this Jul 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants