Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update librsvg to version 2.59.1 #264

Merged

Conversation

sergio-costas
Copy link
Contributor

@sergio-costas sergio-costas commented Dec 3, 2024

This change requires using meson, and also to avoid snapcraft adding $CRAFT_STAGE to the prefix part in librsvg-2.0.pc, since now that .pc file is position-independent thanks to the use of ${pcfiledir}.

Also some changes to the libgweather patch had to be added to enable it to build.

Since the gdk-pixbuf loader is renamed, this PR should NOT be merged until canonical/snapcraft-desktop-integration#30 is fully available in the build pipeline.

Copy link
Contributor

@seb128 seb128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The launcher changes landed so we can merge this one and give it a try in candidate now

Copy link
Contributor

@seb128 seb128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it needs manual rebasing first though, could you do that?

This change requires using meson, and also to avoid snapcraft
adding $CRAFT_STAGE to the `prefix` part in librsvg-2.0.pc,
since now that .pc file is position-independent thanks to the
use of ${pcfiledir}.

Also some changes to the libgweather patch had to be added to
enable it to build.
@sergio-costas sergio-costas force-pushed the update-librsvg-to-2.59.1 branch from ae3b2e4 to 224dd6f Compare January 16, 2025 11:40
@sergio-costas sergio-costas merged commit b94c47d into ubuntu:gnome-46-2404-sdk Jan 16, 2025
2 checks passed
@sergio-costas
Copy link
Contributor Author

@seb128 Rebased and merged.

@seb128
Copy link
Contributor

seb128 commented Jan 16, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants