You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
adamgulde opened this issue
Jan 29, 2025
· 3 comments
· May be fixed by #112
Assignees
Labels
bugSomething isn't working correctly or something crashes the programmediumSimple enough issue but probably overlooked during initial development.MVPRequired for minimum viable product (ideal deadline: Dec. 11)
Relevant TODO can be found in banker.py get_client_by_socket() function. Search for "TODO" using ctrl-f and you'll find it in a large commented block. Please read the whole comment.
The idea here is, when the banker is searching through its locally saved list of players, it will return the first player with the same IP address which it's searching for. An issue will arise, then, for example, whenever you expect the second player to be returned in this context, but you are running everything locally [on the same IP]. Thus, you will return the first player, not the second, which will lead to undesirable behavior. I also think this is what is causing tic tac toe to fail locally, so it's pretty important that this becomes more robust.
DM on Discord if you need help or more clarification (username: indev31).
The text was updated successfully, but these errors were encountered:
adamgulde
added
bug
Something isn't working correctly or something crashes the program
medium
Simple enough issue but probably overlooked during initial development.
MVP
Required for minimum viable product (ideal deadline: Dec. 11)
labels
Jan 29, 2025
@fmcubium Update on this? Also, for this issue especially, make sure you're testing with the latest code from the Github. Some changes may have impacted and fixed part of this issue
bugSomething isn't working correctly or something crashes the programmediumSimple enough issue but probably overlooked during initial development.MVPRequired for minimum viable product (ideal deadline: Dec. 11)
Relevant TODO can be found in banker.py get_client_by_socket() function. Search for "TODO" using ctrl-f and you'll find it in a large commented block. Please read the whole comment.
The idea here is, when the banker is searching through its locally saved list of players, it will return the first player with the same IP address which it's searching for. An issue will arise, then, for example, whenever you expect the second player to be returned in this context, but you are running everything locally [on the same IP]. Thus, you will return the first player, not the second, which will lead to undesirable behavior. I also think this is what is causing tic tac toe to fail locally, so it's pretty important that this becomes more robust.
DM on Discord if you need help or more clarification (username: indev31).
The text was updated successfully, but these errors were encountered: