Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly fixes
banker.get_client_by_socket()
to function as intended. The function should return the correct client regardless of what port they are on as long as they are connected and included in theclients
list.The only problem related to this issue is now that an OSError occurs when comparing the two sockets, saying that an operation was attempted on something that is not a socket. This should be false as running
type(socket)
returns the expected<class: socket.socket>
.Fixes #77