Adding roulette.py for a roulette mini-game #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamgulde
reviewed
Feb 17, 2025
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| asyncio.run(main()) |
There was a problem hiding this comment.
Please explain the usage of asyncio here. It may work, and could be a powerful tool in place of threading, but I would like to know exactly what it is accomplishing here.
adamgulde
requested changes
Feb 17, 2025
There was a problem hiding this comment.
See comments in roulette.py.
Please restructure the file to have at least a play() function and a game_title variable. Also instead of get_bet, have your play() function take in a bet integer parameter. Look at how blackjack and coin_flip do these things.
Please add comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.