Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display port #117

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Display port #117

wants to merge 3 commits into from

Conversation

Programmer9876
Copy link

Fixed it to only show ports for banker and connect successfully

adamgulde
adamgulde reviewed Feb 17, 2025
View reviewed changes
adamgulde
adamgulde requested changes Feb 17, 2025
View reviewed changes
Copy link
Collaborator

@adamgulde adamgulde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment/discussion in test_get_port.py. Also, once you respond to the discussion, rename test_get_port to something more descriptive (without "test")

@Programmer9876
Copy link
Author

Just made the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgulde adamgulde adamgulde requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Programmer9876 @adamgulde