Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Higher/Lower game to casino folder #127

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

PhilStef
Copy link

Just a small addition to the game. Formatted it like the blackjack game. Might still be little things to fix inside but the structure and game is there.

Copy link
Collaborator

@adamgulde adamgulde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and I'm sure it works well. The issue is you did not pull the latest changes from the codebase since commit f168d5b, and thus, it crashes when I try to test it with the updated codebase. If you look at commit 7563d15, you'll notice the update_quadrant() function no longer exists in screenspace.py, in favor of a better Terminal class which handles updating itself. Review the changed files in those commits, then update your code correspondingly and update this PR. Good work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants