v15: Remove old values from checkboxlist #17936
Conversation
| this.#selection = this.#selection.filter((selectedItem) => | ||
| this._list.some((listItem) => listItem.value === selectedItem), | ||
| ); | ||
| this.dispatchEvent(new UmbPropertyValueChangeEvent()); |
There was a problem hiding this comment.
Hi @Zeegaan I would recommend making sure we only fire this change event if the configuration did make a change. I think you could compare length before and after?
There was a problem hiding this comment.
I am wondering whether this is the best solution to the editor person updating the values. What happens with this change is that any persisted values, that are not found in the configuration are removed, but only if you go to all content pages and hit Save. We cannot do anything about the content in this case, i.e. we cannot and will not make a content migration. However, just removing the old "invisible" values also doesn't seem to tell the user what is going on, e.g. when the user hits Save, we are just removing the old values behind-the-scenes.
What if we instead showed the user the old values in a way that would indicate, that they are indeed still stored, but the user has to make the active choice to remove them? This could probably be designed in a way to make a clear indication that old values would trigger the validation system to mark the field as invalid?
@nielslyngsoe any thoughts on this?
|
@iOvergaard I'm not opposed to that idea, but that is out of scope for my front-end competencies 🤣 |
Now with your backend validator and automatic mapping to the frontend validation system, we might not need frontend validation for the part, but let's see - good idea! Let's see what @nielslyngsoe thinks about showing the invalid values so that you can still save your content without losing any data before you have implemented an alternative. |
Fixes #9417
Notes
prevaluesin the checkbox listHow to test