Regression fix: searcher skip 10k not possible #17977
Open
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyButland
approved these changes
Jan 18, 2025
There was a problem hiding this comment.
This looks fine to me (having read the details on the issue and the latest Examine release).
I don't have a local setup with 10,000+ items to explicitly test, but if you've got and done that, I think my visual inspection will suffice.
Might just be worth adding a comment and/or link to the issue in code, explaining why we've provided the skipTakeMaxResults value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #17920 caused by a breaking change in Examine 3.4
This PR uses the newly added functionality in Examine 3.6 to increase the amount of search results that can be skipped by calculating the max amount needed based on the skip take parameters.
Testing
See reproduction steps in the linked issue
Notes
Checked related controller methods in v13, but they seem to be using the SearchAfter option instead.