Feature/color picker dark theme fix #1057
Conversation
…dark-theme as well
…r, for the preview button
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the color picker component to support a dark theme by replacing hard-coded color values with CSS variables and removing the box shadow from the color preview button in favor of a border.
- Replaces static color values with Umbraco’s CSS variables
- Removes the box shadow and applies a border for the color preview area
- Adjusts borders on the color picker and swatches to align with the design system
Comments suppressed due to low confidence (2)
packages/uui-color-picker/lib/uui-color-picker.element.ts:589
- Verify that '--uui-color-text' is defined across all themes to ensure consistent text contrast. If there's any risk of it being undefined, consider providing a fallback value.
color: var(--uui-color-text);
packages/uui-color-picker/lib/uui-color-picker.element.ts:603
- Ensure that '--uui-color-border' is properly defined in both dark and light themes so that border rendering is consistent. A fallback value might be useful if the variable is not defined.
border: solid 1px var(--uui-color-border);
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1057.westeurope.azurestaticapps.net |
|
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1057.westeurope.azurestaticapps.net |
Removed some of the hard-coded colors so we are able to use the classes Umbraco uses.
I also removed the box shadow from the color preview button and opted in for a border.