Update to Chromium 129.0.6668.58

[Ahrotahn]

This PR updates to Chromium 129.0.6668.58.

Notes:

• all-add-trk-prefixes-to-possibly-evil-connections.patch had some removals for [5766804]

• fix-building-with-prunned-binaries.patch had a decent amount of new additions for existing code due to the changes in [5762356]

• The safebrowsing and remove-unused-preferences-fields patches had changes due to [5783615], [5791493], [5753105], and [5730314]

• The missing-dependencies patch has a new addition due to [5800779] using a base::ThreadPool function without including the header.

• The enable_component_updater gn flag has been removed in [5754151]

Change log
Blog post

[clickot]

portable linux builds fine and runs at least on Manjaro, Ubuntu 20.04/24.04 and Fedora WS 40

[clickot]

portable linux builds also fine for .58

[tpearson-ssc]

Getting a build failure when overlaid on the Debian builds:

../../chrome/browser/ui/lens/lens_overlay_controller.cc:1110:9: error: no member named 'ThreadPool' in namespace 'base'
 1110 |   base::ThreadPool::PostTaskAndReplyWithResult(
      |   ~~~~~~^
2 warnings and 1 error generated.

[Cubik65536]

I'm getting the following error when building on macOS arm64:

[740/63782] LINK ./protoc-gen-js
FAILED: protoc-gen-js protoc-gen-js.dSYM/Contents/Info.plist protoc-gen-js.dSYM/Contents/Resources/DWARF/protoc-gen-js
TOOL_VERSION=1726610393 ../../build/toolchain/apple/linker_driver.py -Wcrl,driver,../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wcrl,strippath,/Applications/Xcode-16.0.0-Beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/strip -Wcrl,installnametoolpath,../../third_party/llvm-build/Release+Asserts/bin/llvm-install-name-tool  -Wcrl,dsym,. -Wcrl,dsymutilpath,/usr/bin/dsymutil  -fuse-ld=lld -Wl,--icf=all -Wl,--color-diagnostics -Wl,-mllvm,-instcombine-lower-dbg-declare=0 -Wl,-mllvm,-split-threshold-for-reg-with-hint=0 -Wl,-cache_path_lto,thinlto-cache -Wl,--thinlto-cache-policy=cache_size=10\%:cache_size_bytes=40g:cache_size_files=100000 -flto=thin -Wl,--thinlto-jobs=all -Wl,-mllvm,-import-instr-limit=30 -Wcrl,object_path_lto -Wl,-mllvm,-disable-auto-upgrade-debug-info -Wl,-mllvm,-inlinehint-threshold=360 -fwhole-program-vtables -Wl,--strict-auto-link -Wl,--no-call-graph-profile-sort --target=arm64-apple-macos -Wl,-mllvm,-enable-machine-outliner=never -no-canonical-prefixes -Wl,-dead_strip -Wl,-no_data_in_code_info -Wl,-no_function_starts -nostdlib++ -isysroot ../../../../../../../Applications/Xcode-16.0.0-Beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.0.sdk -mmacos-version-min=11.0 -Wl,--lto-O0 -Wl,-ObjC -Wcrl,strip,-x,-S -Wl,--no-warn-duplicate-rpath -Wl,-no_warn_duplicate_libraries -o "./protoc-gen-js" "@./protoc-gen-js.rsp"
ld64.lld: error: unknown argument '--no-warn-duplicate-rpath'
ld64.lld: error: unknown argument '-no_warn_duplicate_libraries'
clang++: error: linker command failed with exit code 1 (use -v to see invocation)

[tpearson-ssc]

Getting a build failure when overlaid on the Debian builds:

Looks like this patch fixes it, no other compilation failures:

--- chrome/browser/ui/lens/lens_overlay_controller.cc
+++ chrome/browser/ui/lens/lens_overlay_controller.cc
@@ -9,6 +9,7 @@
 #include "base/metrics/histogram_functions.h"
 #include "base/no_destructor.h"
 #include "base/system/sys_info.h"
+#include "base/task/thread_pool.h"
 #include "base/task/bind_post_task.h"
 #include "base/task/sequenced_task_runner.h"
 #include "chrome/browser/feedback/show_feedback_page.h"

[Cubik65536]

I'm getting the following error when building on macOS arm64:

[740/63782] LINK ./protoc-gen-js
FAILED: protoc-gen-js protoc-gen-js.dSYM/Contents/Info.plist protoc-gen-js.dSYM/Contents/Resources/DWARF/protoc-gen-js
TOOL_VERSION=1726610393 ../../build/toolchain/apple/linker_driver.py -Wcrl,driver,../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wcrl,strippath,/Applications/Xcode-16.0.0-Beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/strip -Wcrl,installnametoolpath,../../third_party/llvm-build/Release+Asserts/bin/llvm-install-name-tool  -Wcrl,dsym,. -Wcrl,dsymutilpath,/usr/bin/dsymutil  -fuse-ld=lld -Wl,--icf=all -Wl,--color-diagnostics -Wl,-mllvm,-instcombine-lower-dbg-declare=0 -Wl,-mllvm,-split-threshold-for-reg-with-hint=0 -Wl,-cache_path_lto,thinlto-cache -Wl,--thinlto-cache-policy=cache_size=10\%:cache_size_bytes=40g:cache_size_files=100000 -flto=thin -Wl,--thinlto-jobs=all -Wl,-mllvm,-import-instr-limit=30 -Wcrl,object_path_lto -Wl,-mllvm,-disable-auto-upgrade-debug-info -Wl,-mllvm,-inlinehint-threshold=360 -fwhole-program-vtables -Wl,--strict-auto-link -Wl,--no-call-graph-profile-sort --target=arm64-apple-macos -Wl,-mllvm,-enable-machine-outliner=never -no-canonical-prefixes -Wl,-dead_strip -Wl,-no_data_in_code_info -Wl,-no_function_starts -nostdlib++ -isysroot ../../../../../../../Applications/Xcode-16.0.0-Beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.0.sdk -mmacos-version-min=11.0 -Wl,--lto-O0 -Wl,-ObjC -Wcrl,strip,-x,-S -Wl,--no-warn-duplicate-rpath -Wl,-no_warn_duplicate_libraries -o "./protoc-gen-js" "@./protoc-gen-js.rsp"
ld64.lld: error: unknown argument '--no-warn-duplicate-rpath'
ld64.lld: error: unknown argument '-no_warn_duplicate_libraries'
clang++: error: linker command failed with exit code 1 (use -v to see invocation)

I think update to LLVM will solve this issue, but I am waiting for LLVM to build, or I will remove these flags (ref).

[Ahrotahn]

@tpearson-ssc That change is already in the PR in upstream-fixes/missing-dependencies.patch

@Cubik65536 The first argument was added because of #99289, so if the version you're building has that change then it should be fine.
The second argument was added for ios builds. Removing both should allow you to use your current version of LLVM.

[Cubik65536]

@Cubik65536 The first argument was added because of #99289, so if the version you're building has that change then it should be fine. The second argument was added for ios builds. Removing both should allow you to use your current version of LLVM.

Yeah, I've seen the LLVM Project PR. The LLVM that is building on GitHub Action now will include #99289, and I will just remove the second later.