Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor JS test data generating fns to use .filter() when sampling #283

Closed
echeran opened this issue Aug 19, 2024 · 1 comment · Fixed by #334
Closed

Refactor JS test data generating fns to use .filter() when sampling #283

echeran opened this issue Aug 19, 2024 · 1 comment · Fixed by #334

Comments

@echeran
Copy link
Collaborator

echeran commented Aug 19, 2024

This issue could become obsolete if/when we generate data straight from CLDR. But for now, with the JS code, we can:

  1. Refactoring test data sampling code to a common function rather than reimplement that logic in each component's test data generator
  2. Instead of manual logic for taking every nth element of a collection, reuse JS's FP functions and a one-liner (alternative formulation).
@sven-oly
Copy link
Collaborator

Working on this now.

sven-oly added a commit that referenced this issue Nov 7, 2024
* Update NodeJS generators to use .filter for subsampling. Issue #283

* Simplify sampling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants