relative date time format: add numeric options and use in format testing #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echeran
reviewed
Aug 19, 2024
| @@ -46,6 +47,64 @@ const numeric = ['auto', 'always']; | |||
|
|
|||
| const counts = [-100, -4, -2, -1, 0, 1, 1.3, 2, 3, 4, 10]; | |||
|
|
|||
| function sample_tests(all_tests, run_limit) { | |||
testgen/generators/rdt_fmt_gen.js
Outdated
Comment on lines
159
to
163
| let all_options_numeric_always = {...all_options}; | ||
| all_options_numeric_always['numeric'] = 'always'; | ||
|
|
||
| let all_options_numeric_auto = {...all_options}; | ||
| all_options_numeric_auto['numeric'] = 'auto'; |
There was a problem hiding this comment.
You can combine these JS object/dictionary initializations even further via the spread operator. They can each be just one line:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_syntax#description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #263
Fixes #274
Fixes #276
This fixes lots of the test failures with RDTF. It adds tests for numeric with "auto" and "always" options.