Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22793 Clang-Tidy: google-readability-casting #3190

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

roubert
Copy link
Member

@roubert roubert commented Sep 19, 2024

https://releases.llvm.org/19.1.0/tools/clang/tools/extra/docs/clang-tidy/checks/google/readability-casting.html

Before running clang-tidy this time, I temporarily replaced UBool with bool to make it find superfluous such casts. This PR covers what was not already included in commit 0178a07.

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22793
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

eggrobin
eggrobin previously approved these changes Sep 19, 2024
icu4c/source/common/ucnvmbcs.cpp Outdated Show resolved Hide resolved
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/common/ucnvmbcs.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@roubert roubert merged commit 55c5895 into unicode-org:main Sep 19, 2024
94 checks passed
@roubert roubert deleted the 22793-tidy branch September 19, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants