no-alloc more crates #6078
Merged
no-alloc more crates #6078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
force-pushed
the
alloc
branch
12 times, most recently
from
dee71ce to
435308d
Compare
robertbastian
requested review from
Manishearth,
sffc,
zbraniecki,
aethanyc,
makotokato,
hsivonen,
echeran,
nciric,
dminor and
a team
as code owners
robertbastian
removed request for
a team,
aethanyc,
dminor,
zbraniecki and
hsivonen
Manishearth
previously approved these changes
Feb 10, 2025
utils/zerovec/src/cow.rs
Outdated
| } | ||
|
|
||
| // This is mostly just a `Cow<[u8]>`, safe to implement Send and Sync on | ||
| unsafe impl<'a, V: ?Sized> Send for VarZeroCow<'a, V> {} | ||
| unsafe impl<'a, V: ?Sized> Sync for VarZeroCow<'a, V> {} | ||
|
|
||
| #[cfg(feature = "alloc")] |
There was a problem hiding this comment.
thought: clone can technically work in no-alloc
Manishearth
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6076
This no-allocs everything except for crates that use:
CowZeroMap