Add Duplicate Variant error #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eemeli
added
syntax
Co-authored-by: Addison Phillips <[email protected]>
aphillips
approved these changes
Aug 6, 2024
catamorphism
approved these changes
Aug 7, 2024
macchiati
reviewed
Aug 7, 2024
| @@ -369,6 +369,9 @@ satisfied: | |||
| - At least one _variant_ MUST exist whose _keys_ are all equal to the "catch-all" key `*`. | |||
| - Each _selector_ MUST have an _annotation_, | |||
| or contain a _variable_ that directly or indirectly references a _declaration_ with an _annotation_. | |||
| - Each _variant_ MUST use a list of _keys_ that is unique from that | |||
| of all other _variants_ in the _message_. | |||
| _Literal_ _keys_ are compared by their contents, not their syntactical appearance. | |||
There was a problem hiding this comment.
Suggested change
| _Literal_ _keys_ are compared by their contents, not their syntactical appearance. | |
| _Literal_ _keys_ are compared by their contents, not their syntactical appearance. | |
| Keys are considered the same if they are canonically equivalent. | |
| See [Canonical and Compatibility Equivalence](https://unicode.org/reports/tr15/#Canon_Compat_Equivalence) |
Unicode conformance allows (and encourages) implementations to normalize canonically equivalent characters. This is a very common operation when text is input and/or processed. Without this step, there are cases where one implementation would return this error and another would not.
There was a problem hiding this comment.
Canonical equivalence looks like a pretty good idea, but we should apply it to all the places where we do such comparisons. But I think that's a separate change from this PR that I explicitly left out:
This does not address the questions about identifier normalization also raised in the parent issue; that should be done in a separate PR.
|
Makes sense
…On Wed, Aug 7, 2024, 12:15 Eemeli Aro ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In spec/syntax.md
<#853 (comment)>
:
> @@ -369,6 +369,9 @@ satisfied:
- At least one _variant_ MUST exist whose _keys_ are all equal to the "catch-all" key `*`.
- Each _selector_ MUST have an _annotation_,
or contain a _variable_ that directly or indirectly references a _declaration_ with an _annotation_.
+- Each _variant_ MUST use a list of _keys_ that is unique from that
+ of all other _variants_ in the _message_.
+ _Literal_ _keys_ are compared by their contents, not their syntactical appearance.
Canonical equivalence looks like a pretty good idea, but we should apply
it to all the places where we do such comparisons. But I think that's a
separate change from this PR that I explicitly left out:
This does not address the questions about identifier normalization also
raised in the parent issue; that should be done in a separate PR.
—
Reply to this email directly, view it on GitHub
<#853 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMAN5YTSEHS2YVK3CITZQJW6BAVCNFSM6AAAAABMARH7CSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMRVHE4TSNJUHE>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #847 for context and discussion.
This does not address the questions about identifier normalization also raised in the parent issue; that should be done in a separate PR.