feat: use new hash types across the workspace #2984
Draft
+2,250
−2,139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fully migrates all of our hash types to the new
Hash<BYTES, E>
type.most of the diff is adding
::new
and<>
. the changes inssz/
can be largely ignored, as this is generated code.this will also allow us to deprecate/ remove a lot of logic we have in
serde-utils
.some notes:
Hash::get
returns&[u8; BYTES]
; if we deem this to be too unergonomic we can change it to returning a copy instead.<TYPE>
instead of justTYPE
in some places. if you're curious about why dm me, its too dark to explain herefuture work:
Vec<u8>