Skip to content

Commit

Permalink
tags, global, fix: types of user options specifing the executables
Browse files Browse the repository at this point in the history
They should be "string" because they can also be the name (not the path)
of the executable, if it's in the PATH.

See #120 (comment).
  • Loading branch information
AmaiKinono committed Apr 21, 2024
1 parent 6274067 commit 939aca8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions citre-global.el
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,14 @@
"The name or path of the gtags program.
Set this if gtags is not in your PATH, or its name is not
\"gtags\"."
:type '(set file (const nil))
:type '(set string (const nil))
:group 'citre)

(defcustom citre-global-program nil
"The name or path of the GNU Global program.
Set this if global is not in your PATH, or its name is not
\"global\"."
:type '(set file (const nil))
:type '(set string (const nil))
:group 'citre)

(defcustom citre-gtags-args '("--compact" "--objdir")
Expand Down
2 changes: 1 addition & 1 deletion citre-readtags.el
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ Set this if readtags is not in your PATH, or its name is not
\"readtags\".
Citre requires the readtags program provided by Universal Ctags."
:type '(set file (const nil))
:type '(set string (const nil))
:group 'citre)

;;;; Internals: Basic Helpers
Expand Down

2 comments on commit 939aca8

@fuzy112
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m afraid this is still not correct.
The value of type (set types…) is a list. Probably what you need is choice. See https://www.gnu.org/software/emacs/manual/html_node/elisp/Composite-Types.html

@AmaiKinono
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fuzy112 Thanks. Fixed in d0639a9.

Please sign in to comment.