Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More human friendly dates for nightly releases #195

Open
pi0 opened this issue Jun 3, 2024 · 1 comment
Open

More human friendly dates for nightly releases #195

pi0 opened this issue Jun 3, 2024 · 1 comment
Labels
discussion enhancement New feature or request

Comments

@pi0
Copy link
Member

pi0 commented Jun 3, 2024

Suggestion by @IgorMinar (unjs/unenv#246)

Additionally, it would be great to make the timestamp in the version tag human readable. Perhaps: 202405311022.

Currently, it looks like 1.9.1-1717191795.bd5ba19. I choose this pattern a long time ago for two reasons:

  • Both time and commit are easily traceable from version only
  • The time added first so versions are sortable (not sure if still case for npm registry but back in the days, commit alone was causing npm registry wrongly resolving to older builds) + with seconds precision avoid collision of releases in case of two immediate commits/releases (and it still on rare occasions happens)

We could migrate to some pattern like YYYYMMDD.SEC.COMMIT_HASH to be more human readable. Ideas welcome before update
@pi0 pi0 added enhancement New feature or request discussion labels Jun 3, 2024
@pi0 pi0 mentioned this issue Jun 3, 2024
Closed
@IgorMinar
Copy link

YYYYMMDD.SEC.COMMIT_HASH would work for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@IgorMinar @pi0