Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unenv-nightly versioning is problematic #246

Closed
IgorMinar opened this issue May 31, 2024 · 4 comments
Closed

unenv-nightly versioning is problematic #246

IgorMinar opened this issue May 31, 2024 · 4 comments
Assignees

Comments

@IgorMinar
Copy link
Collaborator

IgorMinar commented May 31, 2024

Environment

unenv-nightly

Reproduction

pnpm info unenv-nightly versions

Describe the bug

the unenv-nightly@latest flip flops between patch and minor version bumps

For example after https://github.com/unjs/unenv/actions/runs/9323911293/job/25668071381, the @latest was set to 1.10:

[info] Bumping npm package version from `1.9.0` to `1.10.0-1717187105.3931166` (minor)

But subsequently when another fix was released in https://github.com/unjs/unenv/actions/runs/9324677049/job/25670351927 the @latest became 1.9.x:

[info] Bumping npm package version from `1.9.0` to `1.9.1-1717191795.bd5ba19` (patch)

Ideally all releases from main target 1.10 or even 2.0 release train regardless of their semantic commit message.

Additionally, it would be great to make the timestamp in the version tag human readable. Perhaps: 202405311022.

Additional context

No response

Logs

No response

@pi0
Copy link
Member

pi0 commented May 31, 2024

ah i think we need to clone git in CI (default is 1 and therefore change log id based on last commit)

@pi0 pi0 closed this as completed in 1cf935a May 31, 2024
@IgorMinar
Copy link
Collaborator Author

awesome! thanks

@IgorMinar
Copy link
Collaborator Author

@pi0 could you please also adjust the timestamp format as suggested above?

@pi0
Copy link
Member

pi0 commented Jun 3, 2024

~> unjs/changelogen#195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants