chore: migrate to eslint v9 #150
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import unjs from "eslint-config-unjs"; | ||
|
|
||
| export default unjs({ | ||
| ignores: ["dist", "node_modules", "src/_parser.ts", "coverage"], | ||
| rules: { | ||
| // https://github.com/sindresorhus/eslint-plugin-unicorn | ||
| "unicorn/no-process-exit": 0, | ||
| }, | ||
| }); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,8 +22,8 @@ | |
| "scripts": { | ||
| "build": "unbuild", | ||
| "dev": "vitest dev", | ||
| "lint": "eslint . && prettier -c src test", | ||
| "lint:fix": "eslint . --fix && prettier -c src test -w", | ||
| "prepack": "pnpm run build", | ||
| "play": "jiti ./playground/cli.ts", | ||
| "release": "pnpm test && changelogen --release --push && npm publish", | ||
|
|
@@ -33,12 +33,12 @@ | |
| "consola": "^3.2.3" | ||
| }, | ||
| "devDependencies": { | ||
|
There was a problem hiding this comment. This change is not related to this PR. There was a problem hiding this comment. reverted in this commit: 4c0688c |
||
| "@types/node": "^20.14.2", | ||
| "@vitest/coverage-v8": "^1.5.2", | ||
| "automd": "^0.3.7", | ||
| "changelogen": "^0.5.5", | ||
| "eslint": "^9.4.0", | ||
| "eslint-config-unjs": "^0.3.2", | ||
| "jiti": "^1.21.0", | ||
| "prettier": "^3.2.5", | ||
| "scule": "^1.3.0", | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure
distandnode_modulesare already ignored (otherwise, we should ignore them in the shared config).coverageshould be ignore in the shared config.Why ignoring
src/_parser.ts.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Barbapapazes , thank you for your comment.
I checked the settings for
distandcoverageineslint-config-unjs. Therefore, I will delete it.However, with the current settings,
node_moduleswas not included in this (I don't know why).src/_parser.tswas defined in the deleted.eslintignore.I don't know why I added it, so I left it as is.