Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse filter code lose #47

Merged
merged 1 commit into from
Jul 25, 2024
Merged

fix: parse filter code lose #47

merged 1 commit into from
Jul 25, 2024

Conversation

yxw007
Copy link
Contributor

@yxw007 yxw007 commented Jul 25, 2024

There are two problems

  1. Parse refactor,parse filter code lose
  2. The test case asserts api usage errors, causing the test case to not execute correctly

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (44b65da) to head (955c89f).
Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #47   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         5    +4     
  Lines          243       286   +43     
  Branches        66       107   +41     
=========================================
+ Hits           243       286   +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spot thanks!

@pi0 pi0 merged commit d510919 into unjs:main Jul 25, 2024
4 checks passed
@yxw007
Copy link
Contributor Author

yxw007 commented Jul 25, 2024

Nice spot thanks! Nice spot thanks!

Please post a new version, otherwise I will always worry about the issue related to Nuxt and it will be very uncomfortable. thanks

Relative PR: #28215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants