fix: do not automatically return Sec-WebSocket-Protocol header
#142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eltigerchino
changed the title
Sec-WebSocket-Protocol headersSec-WebSocket-Protocol header
eltigerchino
commented
Feb 24, 2025
| "packageManager": "[email protected]" | ||
| "packageManager": "[email protected]", | ||
| "pnpm": { | ||
| "onlyBuiltDependencies": [ |
There was a problem hiding this comment.
This allows the installed deps to execute their build scripts after installing. Seems like it's necessary to add this list to avoid having to approve the builds every time we install packages.
https://pnpm.io/package_json#pnpmonlybuiltdependencies
eltigerchino
commented
Feb 24, 2025
| @@ -1,5 +1,4 @@ | |||
| import type { AdapterOptions, AdapterInstance, Adapter } from "../adapter.ts"; | |||
| import type { WebSocket } from "../../types/web.ts"; | |||
There was a problem hiding this comment.
This import wasn't being used so I removed it. The one that's being used is the import alias WebSocket as WebSocketT,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #141
This PR includes a breaking change that modifies the behaviour of the Node and Deno adapters to no longer automatically accept the first WebSocket protocol the client sends. This makes the behaviour the same across all adapters and prevents errors for Node and Deno when trying to return the
Sec-WebSocket-Protocolheader from theupgradehook.