feat: add withBasicAuth utility for authentication #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry this got stalled, is it possible to rebase PR against |
cjpearson
force-pushed
the
feature/basic-auth
branch
from
5d0e714 to
c8b5835
Compare
|
No worries! This is based on v1, but I'll look into a PR for main as well. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1 #826 +/- ##
=====================================
Coverage ? 71.16%
=====================================
Files ? 62
Lines ? 3326
Branches ? 719
=====================================
Hits ? 2367
Misses ? 938
Partials ? 21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Added a port of this change for v2 here #998 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #551
This change adds a new utility
withBasicAuth. By passing this function an event handler and username/password pair it will return a wrapped event handler which applies basic authentication before calling the inner handler.