fix(cloudflare): bind getRandomValues and randomUUID to the crypto object
#307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
approved these changes
Sep 13, 2024
jasnell
reviewed
Sep 13, 2024
jasnell
reviewed
Sep 13, 2024
petebacondarwin
force-pushed
the
fix-webcrypto-bindings
branch
from
72e9f23
to
96a66ae
Compare
pi0
approved these changes
Sep 15, 2024
pi0
changed the title
getRandomValues and randomUUID to the crypto object
|
Actually this is not correct from some local testing. Please don't merge |
|
Doh! |
|
sorry for merge @petebacondarwin do you want to revert? |
|
No need to revert. This doesn't break anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #306