Change the font used by checkboxes to match UWP #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fonts are now embedded into uno packages |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #22
PR Type
What is the current behavior?
Checkboxes in Uno.Playground use the WinJS Symbols font, leading to the wrong styling.
What is the new behavior?
The checkmark uses Segoe MDL2 Assets instead.
I'm pretty sure this is an absolutely horrible way to fix this, and that changing the default font used in Uno.UI for the Checkbox control would be better.
...Thing is, I couldn't figure out how to fix it there 😅, or if that's wanted. (MDL2 being closed source and all.) Guidance would be most welcome!
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):