Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move CameraCaptureUI to SingleProject Uno.Sdk 5.3 #801

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

morning4coffe-dev
Copy link
Member

@morning4coffe-dev morning4coffe-dev commented Aug 8, 2024

I have tested this on Android, where the image returns well.

I can't test on iOS and I am not sure if the permissions are set correctly at the moment.

On Windows, it currently returns null with WinUI3, there is a pull request on the way at the moment with a API spec microsoft/WindowsAppSDK#4576 and related issue microsoft/WindowsAppSDK#1034

@morning4coffe-dev morning4coffe-dev marked this pull request as ready for review August 10, 2024 12:10
@agneszitte agneszitte marked this pull request as draft August 15, 2024 23:20
@agneszitte
Copy link
Contributor

I have tested this on Android, where the image returns well.

I can't test on iOS and I am not sure if the permissions are set correctly at the moment.

On Windows, it currently returns null with WinUI3, there is a pull request on the way at the moment with a API spec microsoft/WindowsAppSDK#4576 and related issue microsoft/WindowsAppSDK#1034

@morning4coffe-dev FYI microsoft/WindowsAppSDK#4576 is now merged

{
// To update the version of Uno please update the version of the Uno.Sdk here. See https://aka.platform.uno/upgrade-uno-packages for more information.
"msbuild-sdks": {
"Uno.Sdk": "5.3.96"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will need to be rebased with latest and updated to latest 5.4 stable version
Related new issue: #828

@morning4coffe-dev
Copy link
Member Author

I have tested this on Android, where the image returns well.
I can't test on iOS and I am not sure if the permissions are set correctly at the moment.
On Windows, it currently returns null with WinUI3, there is a pull request on the way at the moment with a API spec microsoft/WindowsAppSDK#4576 and related issue microsoft/WindowsAppSDK#1034

@morning4coffe-dev FYI microsoft/WindowsAppSDK#4576 is now merged

Hmm... I think this is only the API spec, that got merged, we will still need to wait for the implementation which should be, once microsoft/WindowsAppSDK#1034 is closed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants