Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Pass Data when nav with TabBar and NavView #2695

Merged
merged 8 commits into from
Feb 27, 2025
Merged

feat: Pass Data when nav with TabBar and NavView #2695

merged 8 commits into from
Feb 27, 2025

Conversation

erikvilima
Copy link
Contributor

GitHub Issue (If applicable): closes #2449

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

Using uen:Navigation.Data AP on TabBarItems and NavigationViewItems doesn't work.

What is the new behavior?

It is now possible to send data using uen:Navigation.Data AP on TabBarItems and NavigationViewItems.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@erikvilima erikvilima self-assigned this Feb 13, 2025
nickrandolph
nickrandolph approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@nickrandolph nickrandolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@erikvilima erikvilima mentioned this pull request Feb 18, 2025
Open
@unodevops
Copy link

⚠️⚠️ The build 155545 has failed on uno.extensions.

@kazo0 kazo0 merged commit 7e88b5c into main Feb 27, 2025
16 of 17 checks passed
@kazo0 kazo0 deleted the dev/erli/2449-pass-data-tabbar-navview branch February 27, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazo0 kazo0 kazo0 approved these changes

@nickrandolph nickrandolph nickrandolph approved these changes

@ajpinedam ajpinedam ajpinedam approved these changes

Assignees

@erikvilima erikvilima

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Navigation] Pass Data when navigating with TabBar and NavigationView
5 participants
@erikvilima @unodevops @nickrandolph @ajpinedam @kazo0