-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add Firebase Cloud Messaging documentation #19718
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Make sure to add it to the ToC. You can find the file in uno/doc/articles/toc.yml. I would suggest putting it somewhere in the Samples & Tutorials
section, as there is already:
Line 125 in b2985e2
- name: How to use MSAL for Azure Authentication |
|
|
@@ -0,0 +1,335 @@ | |||
# Implementing Firebase Cloud Messaging (FCM) in Uno Platform Apps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to add the UID section to the top of the file like we have in the other pages, example:
uno/doc/articles/contributing/guidelines/creating-tests.md
Lines 1 to 3 in 5ddf04c
--- | |
uid: Uno.Contributing.CreatingTests | |
--- |
Just needs to be some sort of relevant unique id for the page. Following the same pattern for other files in this directory, we should probably use something like Uno.Features.FirebaseCloudMessaging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added empty line
fixed numbered list
added UID section to the top of the file
|
GitHub Issue (If applicable): closes #
Originated for content but answers: (#3661)
PR Type
What kind of change does this PR introduce?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):