Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Firebase Cloud Messaging documentation #19718

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mtmattei
Copy link
Contributor

GitHub Issue (If applicable): closes #

Originated for content but answers: (#3661)

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

Copy link
Member

@morning4coffe-dev morning4coffe-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Make sure to add it to the ToC. You can find the file in uno/doc/articles/toc.yml. I would suggest putting it somewhere in the Samples & Tutorials section, as there is already:

- name: How to use MSAL for Azure Authentication

@morning4coffe-dev
Copy link
Member

Also, make sure to take a look on the Markdown syntax, there are a few issues. It wants a changes on the numbered lists to 1. 1. 1. instead of 1. 2. 3. Markdown will automatically render it as a sequential numbered list.

And make sure to add an empty line on the bottom of the document:
image

@unodevops
Copy link
Contributor

⚠️⚠️ The build 158178 has failed on Uno.UI - docs.

@unodevops
Copy link
Contributor

⚠️⚠️ The build 158183 has failed on Uno.UI - docs.

@@ -0,0 +1,335 @@
# Implementing Firebase Cloud Messaging (FCM) in Uno Platform Apps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to add the UID section to the top of the file like we have in the other pages, example:

---
uid: Uno.Contributing.CreatingTests
---

Just needs to be some sort of relevant unique id for the page. Following the same pattern for other files in this directory, we should probably use something like Uno.Features.FirebaseCloudMessaging

Copy link
Contributor Author

@mtmattei mtmattei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added empty line
fixed numbered list
added UID section to the top of the file

@unodevops
Copy link
Contributor

⚠️⚠️ The build 158271 has failed on Uno.UI - docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants