-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(combobox): add resetSearchTermOnSelect
param to ComboboxRoot
#1257
base: main
Are you sure you want to change the base?
feat(combobox): add resetSearchTermOnSelect
param to ComboboxRoot
#1257
Conversation
I managed to rename commit: |
Cool addition @romanhrynevych . Can you check the failing test? 😁 |
@zernonia interesting test case, thanks for such approach, updated in |
clearSearchTermOnSelect
param to ComboboxRoot
resetSearchTermOnSelect
param to ComboboxRoot
@hrynevychroman Great addition, will use this. Could you please finalise this PR by fixing the failing test? 💯 |
@knutole this test case was fixed in radix-vue/radix-vue@ @zernonia could we merge this? |
@zernonia @hrynevychroman This is great, but seems a check is failing: Could this be fixed? We're looking forward to using this fix! Thanks! |
I added the
clearSearchTermOnSelect
prop so that the search term will not automatically clear when Combobox selects triggers. Maybe users will want to select multiple values based on the same search fieldsOriginal Issue: unovue/shadcn-vue#709.
Video example:
radix-vue-combobox-clear-search-term.mp4
Docs updated too: