Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snap points #65

Merged
merged 10 commits into from
Jan 31, 2025
Merged

Fix snap points #65

merged 10 commits into from
Jan 31, 2025

Conversation

anbraten
Copy link
Contributor

closes #63

This currently fixes some reactivity issues where `.value´ wasn't correctly checked. However the issue from #63 with the snap point not being considered when dragging down is still happening.

Copy link

changeset-bot bot commented Sep 10, 2024

🦋 Changeset detected

Latest commit: ee7c43e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vaul-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AverageCakeSlice
Copy link

Any word on when this could be resolved/merged? Could really use this fix for a custom component I'm working on.

@zernonia zernonia marked this pull request as ready for review January 30, 2025 14:16
@zernonia
Copy link
Member

Yo @anbraten , may I know what is the issue you faced on #63? Your PR seems to does fix the snap point and it snaps to correct position!

@anbraten
Copy link
Contributor Author

I honestly forgot what the issue was. AFAIK it was working somehow and just a last bit was still broken.

@zernonia
Copy link
Member

My bad for not checking this PR sooner 😂 I'll will merge this and let's see if there's any other broken pieces

@zernonia zernonia merged commit 46a8414 into unovue:main Jan 31, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snappoints doesn't seem to work
3 participants