-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builds failing with v1.3.1 #51
Comments
I don't have time to address this right now but reverted the breaking PR on master in the meantime. |
@aaronklaassen 1.3.0 breaks as well now with the following error |
FWIW, 1.2.0 builds but does not run:
|
looks like 1.3.0 stopped working too due to the same error @drewbrew posted above |
Broke for us too for a short time this morning, but builds are building again pinned to v1.3.0 |
v1.3.0 stopped working since yesterday and v1.3.1 dosnt work also. |
Same here, luckily |
* remove conditional so Articles link always displays (#527) Co-authored-by: Adam Goldstone <[email protected]> * v1.3.1 causes failure so downgrading to v1.3.0 (#533) see unsplash/comment-on-pr#51 * update page title, now responsive to article title and correctly ends with "GOV.UK" (#537) * change deletion notice to accepted wording (#539) * Hfeyp 597 remove back button on edit page screen (#530) * remove back button from edit page screen * update syntax to newer form of key value assignment, move class assignment outside data assignment * changed behaviour so clicking cancel returns to previous screen * Add space to end of hash Co-authored-by: Rob Nichols <[email protected]> Co-authored-by: Rob Nichols <[email protected]> * Move sentry configuration file to initializers to ensure it is loaded on app start (#546) * Update of gems (#548) * aws-sdk-s3 * devise-security * rails gems to 6.1.4.4 actioncable actionmailbox actionmailer actionpack actiontext actionview activejob activemodel activerecord activestorage activesupport railsties * govspeak * Update tracking id for preprod to use new value (#547) * remove other useful resources section (#542) * remove other useful resources section * add newline at end of file * HFEYP-623 change from flexbox to grid so last line of grid aligns left (#545) * change from flexbox to grid so last line of grid aligns left * change column width to correct calculation * add gem-c-govspeak class to articles (#532) * add gem-c-govspeak class to articles * move gem-c-govspeak class to govuk-body, add to article preview * HFEYP-626 Adds alt text to article feature image with helper (#538) * Add feature image helper to properly format images for articles Added proper styling to the admin preview page, which was missing * Include thumbnail images on index page * Add guard to helper * Use alt text for title attribute * Cms refactor (#506) * refactor content blocks into admin namespace * WIP: refactor content assets into admin namespace * refactor content blocks into admin namespace * remove commented out code * refactor contentPage & versions to admin namespace * minor changes to back button positions * fix rubocop issues * refactor specs * refactor specs * delete routing specs * fix typo * add 404 redirect * refactor feature specs for admin paths * refactor request specs for admin path * refactor view specs for admin paths * refactor for admin path * correct path * add description * fix syntax errors * fix content_pages rspec * remove unnecessary comments * HFEYP-651 Update javascript packages and listen gem (#551) * Update using `yarn upgrade --latest` * Update listen gem * Upgrade using bundle update * Preprod uses staging credentials, not production (#553) * HFEYP-652 remove duplicate spec (#554) * remove duplicate and flaky spec * remove empty spec * Updated with suggestion to remove unused class (#555) Still some concern with the issue that Youtube snippets will not go go through the sanitize method * HFEYP-604 Update styles for contents list (#550) * Add styling from govuk_publishing_component * Move contents list style within govspeak * Revert to using the margins on li elements * add target _blank to open in new tab (#567) * Hfeyp 612 preview labels (#560) * add preview of live to controller and route * add preview label to draft preview page * update links to preview of live page * update preview of live page link * add preview of live page * add preview live spec * correct id * correct path * move to one line * add newline * remove creation of new copy of content page * add aria labels for context Co-authored-by: Brett McHargue <[email protected]> * Hfeyp 199 editor sign in page update (#571) * change header text * change label classes so now smaller text * move line break inside conditional, remove unnecessary line break * change call to action wording Co-authored-by: Brett McHargue <[email protected]> * HFEYP 36 CMS - Change Log out to take user to sign in page (#572) * change sign out redirect to page that user was previously on * add rubocop suggestions * - update failing specs with new behaviour - remove duplicate specs Co-authored-by: Brett McHargue <[email protected]> * Use main as integration branch, rather than develop (#575) * Update gems and packages (#577) Co-authored-by: Adam Goldstone <[email protected]> Co-authored-by: Adam Goldstone <[email protected]> Co-authored-by: Rob Nichols <[email protected]> Co-authored-by: tunde-anddigital <[email protected]>
@aaronklaassen, would it be possible to create a new tag (v1.3.2) from master? With automatic dependency updates (using Renovate bot / dependabot) it's easy to end up on v1.3.1. |
A new tag would indeed be really useful. |
For anyone trying to work around this broken action, I decided to use the - name: Add comment on PR
run: |
cat << EOF | gh pr comment ${{ github.event.pull_request.number }} --body-file -
Hello from
GitHub Actions
EOF
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} Unfortunately, there is no duplication check in the |
See: unsplash/comment-on-pr#51 Signed-off-by: Manuel Hutter <[email protected]>
any updates? |
This also broke our deploys when we upgraded from 1.3.0 to 1.3.1 with the error from the OP:
Reverting to 1.3.0 fixed the issue. I noticed looking through the commits for the change from 1.3.0 to 1.3.1 that there's been a major refactor, would that be worthy of a major/minor version bump rather than a patch version change. |
This exact issue is happening for us too, but it was already happening in 1.3.0 and I was hoping 1.3.1 would fix it :(.
Looks like the CLI route is the way to go. |
Upgrading to
unsplash/[email protected]
causes our builds to fail w/ the following error:Downgrading to
unsplash/[email protected]
fixed our builds for now.The text was updated successfully, but these errors were encountered: