Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Progress tracking and conditional termination from Python #206 #211

Merged
merged 19 commits into from
Sep 5, 2023
Merged

Feature: Progress tracking and conditional termination from Python #206 #211

merged 19 commits into from
Sep 5, 2023

Conversation

mgevor
Copy link
Contributor

@mgevor mgevor commented Aug 23, 2023

No description provided.

@mgevor mgevor marked this pull request as ready for review August 23, 2023 06:09
@mgevor mgevor self-assigned this Aug 23, 2023
@mgevor mgevor added the enhancement New feature or request label Aug 23, 2023
ashvardanian
ashvardanian requested changes Aug 23, 2023
View reviewed changes
include/usearch/index.hpp Show resolved Hide resolved
include/usearch/index.hpp Outdated Show resolved Hide resolved
include/usearch/index.hpp Outdated Show resolved Hide resolved
@ashvardanian
Copy link
Contributor

I believe the index.py file must be affected by these changes, but I can't see it among the changes.
I expect tqdm to receive progress reports from the C++ level. In that case - batch_size argument for add and search will become irrelevant at the Python level, and only log argument will remain. @mgevor, please update accordingly.

@ashvardanian ashvardanian merged commit 98188ee into unum-cloud:main-dev Sep 5, 2023
15 checks passed
@ashvardanian
Copy link
Contributor

🎉 This PR is included in version 2.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashvardanian ashvardanian ashvardanian approved these changes

Assignees

@mgevor mgevor

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgevor @ashvardanian