-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Swift & Obj-C bindings for filteredSearch #471
Add: Swift & Obj-C bindings for filteredSearch #471
Conversation
5420a81
to
100cf62
Compare
gentle ping @ashvardanian 🙏 |
@vardhan, can you please refresh from |
150f950
to
e8bf04c
Compare
Rebased on top of latest |
I can't run it locally right now, but the CI is failing.
This looks like it's coming from your changes, @vardhan. |
Added a couple of tests in Swift to test both functions. Issue: unum-cloud#470
e8bf04c
to
d287a18
Compare
Thanks! I fixed the issues that CI raised. However, when I try to build (
though it doesnt look like CI is hitting this issue. Note that if I checkout an older commit (tag v2.14.0), I don't see any failures. |
That looks like a mistake in the core implementation, that may even be coming from SimSIMD type definitions, where bf16 maps to fp16. That shouldn't happen. |
This was the error I mentioned earlier -- It doesn't seem like it's related to this PR though. Please let me know if CI throws any more issues (I don't have the ability to run it from my fork) In case it matters, I'm building on an |
Thank you, @vardhan! Merged 😉 |
Added a couple of tests in Swift to test both functions.
Tested with
swift build && swift test -v
Issue: #470