Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX-1264: Unify exports #185

Merged
merged 24 commits into from
Oct 2, 2024
Merged

DX-1264: Unify exports #185

merged 24 commits into from
Oct 2, 2024

Conversation

ytkimirti
Copy link
Contributor

@ytkimirti ytkimirti commented Sep 23, 2024

This PR introduces some small tweaks to unify some parts of our javascript packages. Here are the changes:

  • Fix some eslint warnings
  • Used "latest" version in examples for this package
  • Updated tsup config

Note from this discussion: We disable codesplitting for CJS because it is currently experimental in tsup. This resulted in an increased bundle size for CJS.

  • Updated exports field in package.json

NOTE: This should not bring any breaking changes with the old version. Here is the old and new output coming from the attw cli:

q before q after

NOTE: /dist/nextjs import is there just for backwards compatibility.

Copy link

linear bot commented Sep 23, 2024

@@ -1,4 +1,3 @@
name = "cloudflare-workers"
main = "src/index.ts"
compatibility_date = "2022-07-09"
node_compat = true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make sure this doesn't break anything

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we use any nodejs imports, we probably don't need this

@CahidArda CahidArda merged commit 74024e3 into main Oct 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants