feat: allow undefined client token #208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CahidArda
reviewed
Nov 5, 2024
Comment on lines
+277
to
+284
| throw new Error( | ||
| "QStash token is required!\n\n" + | ||
| "To fix this:\n" + | ||
| "1. Get your token from the Upstash Console (https://console.upstash.com/qstash)\n" + | ||
| "2. Initialize the client with:\n\n" + | ||
| " const client = new Client({\n" + | ||
| " token: '<YOUR_QSTASH_TOKEN>'\n" + | ||
| " });" |
There was a problem hiding this comment.
we had issues with throwing in the constructor if the token is missing in redis. more info available here upstash/redis-js#1311
I would prefer if we don't throw but simply log a warning
There was a problem hiding this comment.
what was the issue? Afaik stripe also throws and their dx is incredible, logging is a bit harder to see
There was a problem hiding this comment.
if redis-js is used in turbo repo, it gets an error at compile time unless the env upstash env variables are specified in the turbo.json file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.