Retry on ratelimit status #217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytkimirti
reviewed
Dec 3, 2024
ytkimirti
reviewed
Dec 3, 2024
| @@ -75,6 +76,19 @@ export type RetryConfig = | |||
| * ``` | |||
| */ | |||
| backoff?: (retryCount: number) => number; | |||
There was a problem hiding this comment.
From the comments, I couldn't understand the usecase for the normal backoff. I know ratelimit is applied for 429, but what is this for? Maybe we can explain a bit more in the docstring
There was a problem hiding this comment.
it's for when fetch throws an error, instead of returning a response with some status (200 or non-200)
There was a problem hiding this comment.
Oh ok, after reading the code I understood, a little note in the comments would be very helpfull
|
decided to close this PR and update the default retry duration to be 1 sec in the second retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, we update the qstash-js client to retry ratelimit errors. The client will retry with this algorithm by default
In a nutshell, it's the max of
last backoff + 1sand1-5s. The aim is to spread the load over time while keeping the durations small.