Skip to content

Commit

Permalink
Nps a11y fix (#3382)
Browse files Browse the repository at this point in the history
* Add non-working yaml variant

* Fix voiceover highlighting for nps view

---------

Co-authored-by: crow <[email protected]>
  • Loading branch information
crow and crow authored Feb 19, 2025
1 parent 21b341a commit 2caaeba
Show file tree
Hide file tree
Showing 2 changed files with 982 additions and 2 deletions.
3 changes: 1 addition & 2 deletions Airship/AirshipCore/Source/Score.swift
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ struct Score: View {
) {
makeNumberRangeScoreItems(style: style, constraints: constraints)
}
.accessibilityElement(children: .contain)
} else {
HStack(spacing: style.spacing ?? 0) {
makeNumberRangeScoreItems(style: style, constraints: constraints)
Expand All @@ -62,7 +61,7 @@ struct Score: View {
let constraints = modifiedConstraints()
createScore(constraints)
.thomasCommon(self.info, formInputID: self.info.properties.identifier)
.accessible(self.info.accessible)
.accessible(self.info.accessible, hideIfDescriptionIsMissing: false)
.formElement()
.onAppear {
self.restoreFormState()
Expand Down
Loading

0 comments on commit 2caaeba

Please sign in to comment.