Fix tests and simplify library description #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abitrolly
changed the title
|
@abitrolly Which version of go are you using ? I'm at 1.23.2 |
dearchap
approved these changes
Jan 25, 2025
|
@dearchap I believe this was from 1.18 in CI. My local Go is 1.23.5 from Homebrew. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this test failure by using Go version from
go.mod.But doesn't fix this DNS lookup error that only occurs on GitHub.
=== RUN TestReadURI/Invalid_http_URL uri_source_cache_test.go:55: Error Trace: /home/runner/work/cli-altsrc/cli-altsrc/uri_source_cache_test.go:55 Error: Error "Get \"http://foo\": dial tcp: lookup foo on 127.0.0.53:53: server misbehaving" does not contain "no such host" Test: TestReadURI/Invalid_http_URL `` The example below still lacks proper imports to be standalone.