feat: add draft commit workflow #681
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
keithmanville
force-pushed
the
workflow-draft-commit
branch
2 times, most recently
from
63582d5 to
01f0fba
Compare
keithmanville
force-pushed
the
workflow-draft-commit
branch
2 times, most recently
from
6c2c72e to
047265e
Compare
keithmanville
commented
Jan 24, 2025
src/dioptra/restapi/v1/utils.py
Outdated
| @@ -523,6 +523,32 @@ def build_group(group: models.Group) -> dict[str, Any]: | |||
| } | |||
|
|
|||
|
|
|||
| def build_resource(resource_type: str, resource_dict: dict) -> Any: | |||
There was a problem hiding this comment.
If this isn't being used, remove it.
keithmanville
force-pushed
the
workflow-draft-commit
branch
3 times, most recently
from
f0f8e1b to
7746388
Compare
keithmanville
force-pushed
the
workflow-draft-commit
branch
2 times, most recently
from
65d3945 to
cb87a01
Compare
keithmanville
force-pushed
the
workflow-draft-commit
branch
from
cb87a01 to
f8c6fb0
Compare
This commit adds a new workflow for committing drafts. Committing a draft will create a new resource snapshot and delete the draft in a single transaction. A draft can be either a draft of a new resource or draft modifications to an existing resource. For draft modifications, the commit will be rejected if the snapshot the draft was based off of is not longer the most recent snapshot. In this case an error is raised that contains detailed information about the draft, the base snapshot, and the current snapshot so that the user can reconcile their desired changes. A draft commit can also be rejected if the resource fails to be created for any reason (e.g. name collisions or associations to invalid resources). It also adds the workflow to the Python client and implements new tests for the workflow.
keithmanville
force-pushed
the
workflow-draft-commit
branch
from
f8c6fb0 to
fe734bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.