use local instead of utc in parse_relative_time #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
@tertsdiepraam hi, just wondering if there's any progress towards merging this? Happy to make any changes as needed. |
|
I think this has been fixed in #85? |
|
Looks like it, thanks! Any chance we can get a new release with that fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
parse_relative_timefunction is usingUtc::now().date_naive()to get today's date, butparse_relative_time_at_dateusesLocal::now().date_naive(); these two values are subtracted, which gives incorrect results when Utc and Local time span midnight.I think this fixes #36, at least in the short term