Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean slate with Winnow 2 #86

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Clean slate with Winnow 2 #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98dc6aa
start parsing date with winnow
tertsdiepraam Jan 26, 2024
98599f1
Restore the old API and add the missing combinators
dhilst Aug 29, 2024
374e49e
Find a compatibility intersection between chrono and GNU
dhilst Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
409 changes: 306 additions & 103 deletions Cargo.lock
View file
Open in desktop

Large diffs are not rendered by default.

15 changes: 11 additions & 4 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,20 @@
[package]
name = "parse_datetime"
description = "parsing human-readable time strings and converting them to a DateTime"
version = "0.6.0"
version = "0.7.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the api didn't change?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this was before recreating the parse_datetime function, I'm restoring it to 6

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I setting this to 0.7.0. The API didn't change, for one minute I found that 0.6.1 was the right version, but this is not a simple bugfix so I think 0.7.0 is the correct choice.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine, i was just curious :)

edition = "2021"
license = "MIT"
repository = "https://github.com/uutils/parse_datetime"
readme = "README.md"

[dependencies]
regex = "1.10.4"
chrono = { version="0.4.38", default-features=false, features=["std", "alloc", "clock"] }
nom = "7.1.3"
chrono = { version="0.4", default-features=false, features=["std", "alloc", "clock"] }
num-traits = "0.2.19"
winnow = { version="0.5.34"}

[dev-dependencies]
anyhow = "1.0.86"
#winnow = { version="0.5.34", features = ["debug"] }

[features]
debug = ["winnow/debug"]
226 changes: 202 additions & 24 deletions fuzz/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions fuzz/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ chrono = { version="0.4", default-features=false, features=["std", "alloc", "clo
[dependencies.parse_datetime]
path = "../"

[features]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, why in this PR ?

Copy link
Author

@dhilst dhilst Sep 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To see the trace output I need build it with winnow/debug/ feature. I tried cargo fuzz --features winnow/debug but it didn't worked. So I added this debug feature that depends on winnow/debug and I can enable it instead

debug = ["parse_datetime/debug"]

[[bin]]
name = "fuzz_parse_datetime"
path = "fuzz_targets/parse_datetime.rs"
Expand Down
Loading