Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dmesg filtering options (--facility, --level, --since, and --until options). #167

Merged
merged 22 commits into from
Dec 15, 2024

Conversation

fuad1502
Copy link
Contributor

@fuad1502 fuad1502 commented Dec 9, 2024

This PR is a continuation of issue #14

I also implemented RecordIterator in this PR. The reasons are as follows:

  • It makes sense to use iterators while implementing filtering options.
  • Later, we need to support "online" reads, which is easier to implement with iterators. (see --follow and --follow-new options)
  • It "might" improve performance (e.g. eliminate multiple passes through the collection, no need to store intermediary results, potentially better optimized.)

To Do:

  • facility
  • level
  • since
  • until

@fuad1502 fuad1502 marked this pull request as ready for review December 12, 2024 06:40
Co-authored-by: Daniel Hofstetter <[email protected]>
@cakebaker cakebaker merged commit 7c7809e into uutils:main Dec 15, 2024
13 checks passed
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (f621687) to head (e6364af).
Report is 52 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #167   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cakebaker
Copy link
Contributor

Good work, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants