Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ctrlaltdel #31

Merged
merged 4 commits into from
May 12, 2024
Merged

Implement ctrlaltdel #31

merged 4 commits into from
May 12, 2024

Conversation

sisungo
Copy link
Contributor

@sisungo sisungo commented Apr 13, 2024

No description provided.

@sylvestre
Copy link
Contributor

looks great, could you please add a few tests?

Copy link

codecov bot commented Apr 13, 2024

Codecov Report

Attention: Patch coverage is 41.42857% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 40.06%. Comparing base (3105da1) to head (5323306).
Report is 30 commits behind head on main.

❗ Current head 5323306 differs from pull request most recent head d6c20a9. Consider uploading reports for the commit d6c20a9 to get more accurate results

Files Patch % Lines
src/uu/ctrlaltdel/src/ctrlaltdel.rs 35.93% 35 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   39.80%   40.06%   +0.26%     
==========================================
  Files           9       11       +2     
  Lines        1437     1520      +83     
  Branches      176      200      +24     
==========================================
+ Hits          572      609      +37     
- Misses        780      815      +35     
- Partials       85       96      +11     
Flag Coverage Δ
macos_latest 38.56% <36.66%> (?)
ubuntu_latest 40.25% <40.62%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisungo
Copy link
Contributor Author

sisungo commented Apr 14, 2024

Some unit tests were added.

@cakebaker cakebaker merged commit c9ee7d6 into uutils:main May 12, 2024
12 of 13 checks passed
@cakebaker
Copy link
Contributor

Thanks for your PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants