Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include utility headers in ranges_defs.h #2066

Open
mmichel11 opened this issue Feb 13, 2025 · 0 comments
Open

Do not include utility headers in ranges_defs.h #2066

mmichel11 opened this issue Feb 13, 2025 · 0 comments

Comments

@mmichel11
Copy link
Contributor

This issue was initially brought up in #2065 (comment).

ranges_defs.h adds our internal ranges along with nanoranges into our public namespaces. This header includes utils_ranges.h along with hetero/dpcpp/utils_ranges_sycl.h in order to obtain our internal range definitions. We include this header in ./hetero/dpcpp/parallel_backend_sycl.h and glue_algorithm_ranges_impl.h.

As suggested in the comment, we should not be include utility headers ranges_defs.h but rather provide forward declarations at this level to our internal range classes. This removes the risk of circular dependencies that was fixed in #2065.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant