You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ranges_defs.h adds our internal ranges along with nanoranges into our public namespaces. This header includes utils_ranges.h along with hetero/dpcpp/utils_ranges_sycl.h in order to obtain our internal range definitions. We include this header in ./hetero/dpcpp/parallel_backend_sycl.h and glue_algorithm_ranges_impl.h.
As suggested in the comment, we should not be include utility headers ranges_defs.h but rather provide forward declarations at this level to our internal range classes. This removes the risk of circular dependencies that was fixed in #2065.
The text was updated successfully, but these errors were encountered:
This issue was initially brought up in #2065 (comment).
ranges_defs.h
adds our internal ranges along with nanoranges into our public namespaces. This header includesutils_ranges.h
along withhetero/dpcpp/utils_ranges_sycl.h
in order to obtain our internal range definitions. We include this header in./hetero/dpcpp/parallel_backend_sycl.h
andglue_algorithm_ranges_impl.h
.As suggested in the comment, we should not be include utility headers
ranges_defs.h
but rather provide forward declarations at this level to our internal range classes. This removes the risk of circular dependencies that was fixed in #2065.The text was updated successfully, but these errors were encountered: