Fix circular dependency between utils_ranges_sycl.h and ranges_defs.h #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Michel <[email protected]>
Signed-off-by: Matthew Michel <[email protected]>
mmichel11
requested review from
timmiesmith,
akukanov,
MikeDvorskiy,
dmitriy-sobolev,
danhoeflinger and
adamfidel
dmitriy-sobolev
approved these changes
Feb 13, 2025
|
The patch is OK as a quick fix, But in the long run, the fix should be different. Namely, I believe |
|
@mmichel11 would you please open an issue capturing @akukanov's direction for the correct fix? |
timmiesmith
pushed a commit
that referenced
this pull request
Feb 13, 2025
…#2065) --------- Signed-off-by: Matthew Michel <[email protected]>
|
I have opened #2066 which will remove these utility header includes and use forward declarations instead. |
timmiesmith
added a commit
that referenced
this pull request
Feb 13, 2025
…#2065) (#2067) --------- Signed-off-by: Matthew Michel <[email protected]> Co-authored-by: Matthew Michel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1976 introduced a circular dependency between
oneapi/dpl/pstl/hetero/dpcpp/utils_ranges_sycl.handoneapi/dpl/pstl/ranges_defs.h. This shows up as an issue in kernel templates where the following produces a compiler error:In
utils_ranges_sycl.h, the include was added to be able to use__nanorange::nano::ranges::contiguous_range, so we can fix this by directly including the nanorange header. This resolves the circular dependency and the compilation issue.