-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[oneDPL][ranges] + zip_view implementation for C++20 #1877
Open
MikeDvorskiy
wants to merge
88
commits into
main
Choose a base branch
from
dev/mdvorski/zip_view
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
88 commits
Select commit
Hold shift + click to select a range
86359d6
[oneDPL][ranges][zip_view] + initial implementation of standard compl…
MikeDvorskiy 93a1b42
[oneDPL][ranges][zip_view] + missing arithmetic operations for zip_vi…
MikeDvorskiy ed5d9bf
[oneDPL][ranges][zip_view] + return type fix for operator*()
MikeDvorskiy a5f68a1
[oneDPL][ranges][tuple] + const assignment operator overload
MikeDvorskiy 24b12bb
[oneDPL][ranges][zip_view] + test
MikeDvorskiy ed50010
[oneDPL][ranges][zip_view] + apply_to_tuple instead of std::apply; st…
MikeDvorskiy f9cee36
[oneDPL][ranges][zip_view] + changes in the test
MikeDvorskiy 3307237
[oneDPL][ranges][zip_view] -> oneapi::dpl::ranges
MikeDvorskiy 7222dcf
[oneDPL][ranges][zip_view][test] -> oneapi::dpl::ranges
MikeDvorskiy ff77abc
[oneDPL][ranges][zip_view] + file header and guards
MikeDvorskiy 32552e8
[oneDPL][ranges][zip_view] + apply_to_tuple instead of std::apply; st…
MikeDvorskiy 28124a1
[oneDPL][ranges][zip_view] + begin_imp, end_impl to reduce code dupli…
MikeDvorskiy 8e3e4bf
Revert "[oneDPL][ranges][zip_view] + begin_imp, end_impl to reduce co…
MikeDvorskiy 127f41e
[oneDPL][ranges][zip_view][test] + minor changes
MikeDvorskiy 6b3f64c
[oneDPL][ranges][zip_view] + minor changes
MikeDvorskiy 22fa2e4
[oneDPL][ranges][zip_view] + #include "tuple_impl.h"
MikeDvorskiy a7a086d
[oneDPL][ranges][zip_view][test] + test_zip_view_base_op()
MikeDvorskiy 7c88be6
[oneDPL][ranges][zip_view] + implementation fix for 'operator-' betwe…
MikeDvorskiy 0a763a3
Update include/oneapi/dpl/pstl/zip_view_impl.h
MikeDvorskiy a5513f3
Update include/oneapi/dpl/pstl/zip_view_impl.h
MikeDvorskiy 0baed00
Update include/oneapi/dpl/pstl/zip_view_impl.h
MikeDvorskiy 9f9b857
Update include/oneapi/dpl/pstl/zip_view_impl.h
MikeDvorskiy 7fbc430
Update include/oneapi/dpl/pstl/zip_view_impl.h
MikeDvorskiy 946cf2a
Update include/oneapi/dpl/pstl/zip_view_impl.h
MikeDvorskiy 0b7f380
Update include/oneapi/dpl/pstl/zip_view_impl.h
MikeDvorskiy 28aa293
Update include/oneapi/dpl/pstl/zip_view_impl.h
MikeDvorskiy 4e04664
Update include/oneapi/dpl/pstl/zip_view_impl.h
MikeDvorskiy cfa875c
[oneDPL][ranges][zip_view] + std::get usage
MikeDvorskiy 4cbfe57
[oneDPL][ranges][zip_view] + 'std::forward<decltype(__args)>(__args)'…
MikeDvorskiy cfa29c0
[oneDPL][ranges][zip_view] + 'minor change' for const/non const type …
MikeDvorskiy 1131a2c
[oneDPL][ranges][zip_view] + fix operator<=> implementation
MikeDvorskiy 5d5ceb8
[oneDPL][ranges][zip_view][test] removed cbegin(), cend() test cases …
MikeDvorskiy be339cf
[oneDPL][ranges][zip_view][test] + front(), back() methods check
MikeDvorskiy b62e65c
[oneDPL][ranges][zip_view][test] + empty constructor call check
MikeDvorskiy 0f023d0
[oneDPL][ranges][zip_view][test] + ;
MikeDvorskiy c3388db
[oneDPL][ranges][zip_view][test] const for compare_with_sentinels
MikeDvorskiy 02eb5ea
[oneDPL][ranges][zip_view][test] a fix for zip_view::iterator::operator-
MikeDvorskiy 3c8d9f5
[oneDPL][rfc][zip_view] + std::ranges::range_reference_t usage; it f…
MikeDvorskiy 70d8f81
[oneDPL][ranges][zip_view][test] + minor changes
MikeDvorskiy f6f62a1
[oneDPL][zip_view] + minor improvements
MikeDvorskiy cfd9660
[oneDPL][ranges][zip_view][test] + EXPECT_TRUE usage
MikeDvorskiy b5fbf9e
[oneDPL][ranges][zip_view] + operator oneapi::dpl::zip_iterator<Itera…
MikeDvorskiy 5a9976b
[oneDPL][ranges][zip_view][test] + check conversion to oneapi::dpl::z…
MikeDvorskiy a256c9a
[oneDPL][ranges][zip_view][test] + EXPECT_TRUE usage
MikeDvorskiy bb03833
[oneDPL][ranges][zip_view] + clang format
MikeDvorskiy 72aa720
[oneDPL][ranges][zip_view][test] + result checks
MikeDvorskiy 9c6bfa6
[oneDPL][ranges][zip_view] + LLVM tests for ranges::zip_view (from C+…
MikeDvorskiy 08984c5
[oneDPL][ranges][zip_view] + __simple_view_concep. a fix for operator==
MikeDvorskiy 11094e3
[oneDPL][ranges][zip_view][test] LLVM test begin.pass adaptation for …
MikeDvorskiy b935f84
[oneDPL][ranges][zip_view] + fix for end() and compare_equal
MikeDvorskiy bd2fc48
[oneDPL][ranges][zip_view][test] LLVM test end.pass adaptation for on…
MikeDvorskiy 15866b6
[oneDPL][ranges][zip_view] + fix an error in zip_fn
MikeDvorskiy 04f05e7
[oneDPL][ranges][zip_view][test] LLVM test cpo.pass adaptation for on…
MikeDvorskiy 501ddf2
[oneDPL][ranges][zip_view] + implementation fixes
MikeDvorskiy e7b7c90
[oneDPL][ranges][zip_view][test] LLVM test borrowing.compile.pass ada…
MikeDvorskiy 7e3791b
[oneDPL][ranges][zip_view] + explicit for constructor
MikeDvorskiy e9fa3ed
[oneDPL][ranges][zip_view][test] LLVM test сtad.compile.pass adaptati…
MikeDvorskiy 1e56735
[oneDPL][ranges][zip_view][test] LLVM test сtor.default.pass adaptati…
MikeDvorskiy 5e8bd60
[oneDPL][ranges][zip_view][test] LLVM test general.pass and ctor.view…
MikeDvorskiy c339d19
[oneDPL][ranges][zip_view] + correct implementation of method 'size()…
MikeDvorskiy 2106c65
[oneDPL][ranges][zip_view][test] another couple of LLVM tests adapta…
MikeDvorskiy a5a8480
[oneDPL][ranges][zip_view] + arithmetic operation fixes
MikeDvorskiy eb5f579
[oneDPL][ranges][zip_view][test] LLVM test arithmetict.pass adaptatio…
MikeDvorskiy d5f5616
[oneDPL][ranges][zip_view] + fixes in private zip_view::iterator cons…
MikeDvorskiy 9b0852d
[oneDPL][ranges][zip_view][test] compare.pass test adaptation for oneDPL
MikeDvorskiy 953eb3f
[oneDPL][ranges][zip_view] + fixes in apply_to_tuple using
MikeDvorskiy 8e427fb
[oneDPL][ranges][zip_view][test] another LLVM test portion were adopt…
MikeDvorskiy 0eb08b6
[oneDPL][ranges][zip_view] + iter_move friend method
MikeDvorskiy a766030
[oneDPL][ranges][zip_view][test] another couple of LLVM tests adapta…
MikeDvorskiy a2942ee
[oneDPL][ranges][zip_view] + iter_swap friend method
MikeDvorskiy 3de9dd1
[oneDPL][ranges][zip_view][test] LLVM test iter_swap.pass adaptation …
MikeDvorskiy 9f5f2d3
[oneDPL][ranges][zip_view] + fix: public inheritance for class iterat…
MikeDvorskiy 35bc5dd
[oneDPL][ranges][zip_view][test] another LLVM test adaptation for on…
MikeDvorskiy 6923b5e
[oneDPL][ranges][zip_view][test] another couple of LLVM tests adapta…
MikeDvorskiy e4f2002
[oneDPL][ranges][zip_view][test] + test cases disabling #if __GNUC__ …
MikeDvorskiy 612b5ae
[oneDPL][ranges][tuple] + a fix for default. According to std::tuple:…
MikeDvorskiy 1e8dad9
[oneDPL][ranges][zip_view] + a fix: __maybe_const usage.
MikeDvorskiy dce5f5e
[oneDPL][ranges][zip_view][test] another LLVM tests adaptation for o…
MikeDvorskiy 69771a3
[oneDPL][ranges][zip_view][test] minor changes for begin.pass test
MikeDvorskiy 175dffb
[oneDPL][ranges][zip_view][test] the tests renamed: + prefix "zip_view."
MikeDvorskiy 6ff5b7a
[oneDPL] a fixe for __pattern_walk2 implementation in case of forward…
MikeDvorskiy 7381003
[oneDPL][ranges][zip_view] removed spaces
MikeDvorskiy 5ae1d7c
Revert "[oneDPL] a fixe for __pattern_walk2 implementation in case of…
MikeDvorskiy 1b16802
[oneDPL][ranges][zip_view][test] additional LLVM tests adaptation for…
MikeDvorskiy 6e774ca
[oneDPL][ranges][tuple] + a fix for Value-initializes all elements of…
MikeDvorskiy c2156af
[oneDPL][ranges][zip_view][test] + #include "support/test_config.h"
MikeDvorskiy 11c8521
[oneDPL][ranges][tuple] + a fix for the internal tuple default constr…
MikeDvorskiy 8894166
[oneDPL][ranges][zip_view] + namespace views = ranges::views;
MikeDvorskiy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it is not
const
in practice, and I don't understand how a constoperator=
makes sense in the first place.What am I missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense when we assign constant tuple objects of non-constant references:
https://godbolt.org/z/TP8Gzhvxb (Failing with C++20, but works in C++23)