add namespace in kubernetes commands #420
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbosdo
changed the title
cbosdo
reviewed
Aug 8, 2024
| @@ -39,7 +45,12 @@ func extract(globalFlags *types.GlobalFlags, flags *configFlags, cmd *cobra.Comm | |||
| } | |||
|
|
|||
| if utils.IsInstalled("kubectl") && utils.IsInstalled("helm") { | |||
There was a problem hiding this comment.
It's not the unique case where we check the backend in this function. We probably need to split that a bit better in a future PR
Comment on lines
88
to
95
| errNamespaceCheck := utils.RunCmd("kubectl", "get", "namespace", issuerData.Namespace) | ||
| if errNamespaceCheck != nil { | ||
| errNamespaceCreate := utils.RunCmd("kubectl", "create", "namespace", issuerData.Namespace) | ||
| if errNamespaceCreate != nil { | ||
| log.Fatal().Err(err).Msg(L("Failed to create namespace")) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
An alternative (and possibly cleaner) solution is to add the namespace resource to the issuer yaml we generate above. Adding this at the beginning of the template would let kubernetes do the checks and ensure the namespace is created:
apiVersion: v1
kind: Namespace
metadata:
labels:
name: {{ .Namespace }}
---There was a problem hiding this comment.
Followed your suggestion
Co-authored-by: Cedric Bosdonnat <[email protected]>
Co-authored-by: Cedric Bosdonnat <[email protected]>
Co-authored-by: Cedric Bosdonnat <[email protected]>
Co-authored-by: Cedric Bosdonnat <[email protected]>
Co-authored-by: Cedric Bosdonnat <[email protected]>
rjpmestre
force-pushed
the
check-namespace-definition-in-kubernetes-commands
branch
from
a4f8ff7
to
1754f7b
Compare
cbosdo
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Ensures kubectl commands include the namespace
Test coverage
No tests: manually tested commands while asserting namespace was included
DONE
Links
Issue(s): #375
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Before you merge
Check How to branch and merge properly!